Correct example value type for terminalTotalDifficulty
#648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This fix the example value type of
terminalTotalDifficultyin theengine_exchangeTransitionConfigurationV1definition .According to the schemas in
schemas/uint256,terminalTotalDifficultyshould be auint256, represented as a hex string with0xprefix.However, the current example value of
terminalTotalDifficultyis the numeric0. This PR updates the example value from0to0x0.If we use the existing example value, the request will fail in geth due to a type mismatch.
{"jsonrpc":"2.0","id":0,"error":{"code":-32602,"message":"invalid argument 0: json: cannot unmarshal hex string without 0x prefix into Go struct field TransitionConfigurationV1.terminalTotalDifficulty of type *hexutil.Big"}}By changing the format of the value to a hex string, geth can successfully parse the parameter.
{"jsonrpc":"2.0","id":0,"error":{"code":-32000,"message":"invalid ttd: execution 58750000000000000000000 consensus 0x0"}}Reproduce
Simply changing
"terminalTotalDifficulty": 0leads to the aforementioned error.